tidb
tidb copied to clipboard
lightning: support to limit the source files' data size
What problem does this PR solve?
Issue Number: close #53397
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @zeminzhou. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report
:x: Patch coverage is 15.78947% with 32 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 74.7755%. Comparing base (b3d740f) to head (776488c).
:warning: Report is 3221 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #53435 +/- ##
================================================
+ Coverage 72.5672% 74.7755% +2.2083%
================================================
Files 1505 1535 +30
Lines 429836 441706 +11870
================================================
+ Hits 311920 330288 +18368
+ Misses 98675 90782 -7893
- Partials 19241 20636 +1395
| Flag | Coverage Δ | |
|---|---|---|
| integration | 50.9115% <15.7894%> (?) |
|
| unit | 71.9672% <ø> (-0.1161%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | ∅ <ø> (∅) |
|
| parser | ∅ <ø> (∅) |
|
| br | 50.9842% <ø> (+9.0014%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
/test check-dev
@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test check-dev
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/cc @lance6716 @D3Hunter
@zeminzhou: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-integration-realcluster-test-next-gen | 776488c55fa87cab776639ff77b2919b572b9dd1 | link | true | /test pull-integration-realcluster-test-next-gen |
| pull-unit-test-next-gen | 776488c55fa87cab776639ff77b2919b572b9dd1 | link | true | /test pull-unit-test-next-gen |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.