lightning: allow configure the desired size and number of rows of each INSERT statement for logical mode (#46997)
This is an automated cherry-pick of #46997
What problem does this PR solve?
Issue Number: close #46607
Problem Summary:
What is changed and how it works?
Added a config values tikv-importer.logical-import-batch-{size,rows} which controls how big the INSERT statement would be when using logical mode.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [x] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
In Lightning logical mode, the length of the INSERT statements executed downstream can now be changed from the default 1.0 MiB. Decreasing this allows reducing performance impact caused by large transaction.
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick:
- It must be approved by the approvers firstly.
- AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
:x: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.
:warning: Please upload report for BASE (release-7.5@8e3a55e). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## release-7.5 #53159 +/- ##
================================================
Coverage ? 72.0242%
================================================
Files ? 1411
Lines ? 410720
Branches ? 0
================================================
Hits ? 295818
Misses ? 95016
Partials ? 19886
| Flag | Coverage Δ | |
|---|---|---|
| unit | 72.0242% <53.8461%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 53.9913% <0.0000%> (?) |
|
| parser | ∅ <0.0000%> (?) |
|
| br | 53.4604% <0.0000%> (?) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lance6716 Once this PR has been reviewed and has the lgtm label, please assign easonn7, yujuncen for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
- br/OWNERS
- ~~br/pkg/lightning/OWNERS~~ [lance6716]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-06-04 02:12:48.366278776 +0000 UTC m=+3347322.123414360: :ballot_box_with_check: agreed by lance6716.
/assign @easonn7 @yujuncen
@lance6716: GitHub didn't allow me to assign the following users: easonn7.
Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @easonn7 @yujuncen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.