tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: Set collation to uint16

Open dveeden opened this issue 1 year ago • 15 comments

What problem does this PR solve?

Issue Number: ref #52996

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

dveeden avatar Apr 29 '24 19:04 dveeden

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Apr 29 '24 19:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign d3hunter, qw4990 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 29 '24 19:04 ti-chi-bot[bot]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 19:04 tiprow[bot]

/test all

dveeden avatar Apr 29 '24 19:04 dveeden

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 19:04 tiprow[bot]

/check-issue-triage-complete

dveeden avatar Apr 29 '24 19:04 dveeden

/test all

dveeden avatar Apr 29 '24 19:04 dveeden

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 19:04 tiprow[bot]

/test build

dveeden avatar Apr 29 '24 19:04 dveeden

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 19:04 tiprow[bot]

/ok-to-test

dveeden avatar Apr 29 '24 19:04 dveeden

/test build

dveeden avatar Apr 29 '24 20:04 dveeden

@dveeden: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 20:04 tiprow[bot]

/test build

dveeden avatar Apr 29 '24 20:04 dveeden

@dveeden: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 20:04 tiprow[bot]

/test build

dveeden avatar Apr 29 '24 20:04 dveeden

@dveeden: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 20:04 tiprow[bot]

/test build

dveeden avatar Apr 29 '24 21:04 dveeden

@dveeden: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 21:04 tiprow[bot]

/test all

dveeden avatar Apr 29 '24 21:04 dveeden

/test all

dveeden avatar Apr 30 '24 07:04 dveeden

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.5312%. Comparing base (c60f97d) to head (59639c5). Report is 942 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52997        +/-   ##
================================================
- Coverage   57.7692%   55.5312%   -2.2380%     
================================================
  Files          1409       1614       +205     
  Lines        396668     603512    +206844     
================================================
+ Hits         229152     335138    +105986     
- Misses       150078     245334     +95256     
- Partials      17438      23040      +5602     
Flag Coverage Δ
integration 37.1713% <66.6666%> (?)
unit 71.2499% <96.6666%> (+14.7144%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (∅)
parser ∅ <ø> (∅)
br 44.4775% <ø> (+43.8318%) :arrow_up:

codecov[bot] avatar Apr 30 '24 08:04 codecov[bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar Apr 30 '24 09:04 ti-chi-bot[bot]

/test all

dveeden avatar Apr 30 '24 09:04 dveeden

/retest

dveeden avatar Apr 30 '24 11:04 dveeden

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 59639c5c91eb96bdb9f1309eac40449632c76f3a link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 30 '24 12:04 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 10 '24 19:07 ti-chi-bot[bot]