tidb icon indicating copy to clipboard operation
tidb copied to clipboard

store: remove stores that have no region before balance

Open xzhangxian1008 opened this issue 9 months ago • 6 comments

What problem does this PR solve?

Issue Number: ref #52313

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xzhangxian1008 avatar Apr 29 '24 03:04 xzhangxian1008

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 29 '24 03:04 ti-chi-bot[bot]

/cc @windtalker

xzhangxian1008 avatar Apr 29 '24 03:04 xzhangxian1008

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yangkeao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 29 '24 03:04 ti-chi-bot[bot]

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 03:04 tiprow[bot]

@xzhangxian1008: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 27b776374d9198c134f0854a0a47ef14b30097ba link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 29 '24 03:04 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 70.83333% with 14 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@2ecc47d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52966   +/-   ##
================================================
  Coverage               ?   72.0517%           
================================================
  Files                  ?       1411           
  Lines                  ?     411493           
  Branches               ?          0           
================================================
  Hits                   ?     296488           
  Misses                 ?      95170           
  Partials               ?      19835           
Flag Coverage Δ
unit 72.0517% <70.8333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3144% <0.0000%> (?)

codecov[bot] avatar Apr 29 '24 04:04 codecov[bot]

@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar May 27 '24 02:05 ti-chi-bot[bot]

/retest

xzhangxian1008 avatar May 27 '24 03:05 xzhangxian1008

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 27 '24 03:05 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-05-24 03:42:21.391456029 +0000 UTC m=+2402295.148591602: :ballot_box_with_check: agreed by windtalker.
  • 2024-05-27 04:46:56.158481102 +0000 UTC m=+2665369.915616673: :ballot_box_with_check: agreed by SeaRise.

ti-chi-bot[bot] avatar May 27 '24 04:05 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker, yibin87, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [windtalker,zanmato1984]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 27 '24 08:05 ti-chi-bot[bot]