tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: refine executor code

Open windtalker opened this issue 9 months ago • 8 comments

What problem does this PR solve?

Issue Number: close #52903

Problem Summary:

What changed and how does it work?

  • move join exec related code to tidb/pkg/executor/join
  • move union exec related code to tidb/pkg/executor/union(to avoid cycle import)

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

windtalker avatar Apr 28 '24 09:04 windtalker

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 28 '24 09:04 tiprow[bot]

Codecov Report

Attention: Patch coverage is 94.05204% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 55.8127%. Comparing base (2343c54) to head (db38e17). Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52959         +/-   ##
=================================================
- Coverage   72.3920%   55.8127%   -16.5793%     
=================================================
  Files          1483       1625        +142     
  Lines        429021     605978     +176957     
=================================================
+ Hits         310577     338213      +27636     
- Misses        99142     244513     +145371     
- Partials      19302      23252       +3950     
Flag Coverage Δ
integration 37.0382% <89.8389%> (?)
unit 71.4133% <87.8562%> (+0.1829%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5196% <61.4583%> (+5.3072%) :arrow_up:

codecov[bot] avatar Apr 28 '24 10:04 codecov[bot]

/test unit-test

windtalker avatar Apr 29 '24 05:04 windtalker

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 05:04 tiprow[bot]

/test check-dev2

windtalker avatar Apr 29 '24 06:04 windtalker

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 29 '24 06:04 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 07 '24 02:05 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 09:22:23.291521736 +0000 UTC m=+867497.048657313: :ballot_box_with_check: agreed by guo-shaoge.
  • 2024-05-07 02:32:31.435231818 +0000 UTC m=+929305.192367390: :ballot_box_with_check: agreed by XuHuaiyu.

ti-chi-bot[bot] avatar May 07 '24 02:05 ti-chi-bot[bot]