tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: adjust file directory `br/pkg/restore`

Open Leavrth opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: ref #52877

Problem Summary: Adjust the file directory structure

What changed and how does it work?

Adjust the file directory structure br/pkg/restore. Just move the functions and structs.

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth avatar Apr 28 '24 03:04 Leavrth

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 28 '24 03:04 tiprow[bot]

Codecov Report

Attention: Patch coverage is 71.52778% with 246 lines in your changes are missing coverage. Please review.

Project coverage is 56.0424%. Comparing base (c60f97d) to head (aab524e). Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52944        +/-   ##
================================================
- Coverage   57.7692%   56.0424%   -1.7268%     
================================================
  Files          1409       1617       +208     
  Lines        396668     600964    +204296     
================================================
+ Hits         229152     336795    +107643     
- Misses       150078     240748     +90670     
- Partials      17438      23421      +5983     
Flag Coverage Δ
integration 37.9065% <42.8240%> (?)
unit 71.2331% <55.6713%> (+14.6975%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (∅)
parser ∅ <ø> (∅)
br 56.5537% <71.5277%> (+55.9080%) :arrow_up:

codecov[bot] avatar Apr 28 '24 04:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 30 '24 05:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 09:26:31.863205377 +0000 UTC m=+262945.620340951: :ballot_box_with_check: agreed by 3pointer.
  • 2024-04-30 05:39:05.165606161 +0000 UTC m=+335698.922741734: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar Apr 30 '24 05:04 ti-chi-bot[bot]

/ok-to-test

Leavrth avatar Apr 30 '24 05:04 Leavrth

/retest

Leavrth avatar Apr 30 '24 06:04 Leavrth