tidb icon indicating copy to clipboard operation
tidb copied to clipboard

domain/metrics: add a metric for lease expired time (#47730)

Open ti-chi-bot opened this issue 1 year ago • 5 comments

This is an automated cherry-pick of #47730

What problem does this PR solve?

Issue Number: close #47729

Problem Summary: Add a metric for lease expired time.

What is changed and how it works?

Check List

Tests

  • [ ] Unit test

  • [ ] Integration test

  • [x] Manual test (add detailed scripts or steps below) tiup playground explore & edit & export ... import again & verify the changes ... image

  • [ ] No need to test

    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Apr 27 '24 03:04 ti-chi-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release-7.5@e406d57). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52932   +/-   ##
================================================
  Coverage               ?   72.2847%           
================================================
  Files                  ?       1410           
  Lines                  ?     411102           
  Branches               ?          0           
================================================
  Hits                   ?     297164           
  Misses                 ?      94219           
  Partials               ?      19719           
Flag Coverage Δ
unit 72.2847% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4509% <0.0000%> (?)

codecov[bot] avatar Apr 27 '24 03:04 codecov[bot]

@zimulala @tangenta PTAL

crazycs520 avatar Apr 28 '24 02:04 crazycs520

@crazycs520: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 29 '24 02:04 ti-chi-bot[bot]

@jackysp @hawkingrei PTAL

Tema avatar Apr 30 '24 15:04 Tema

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 02:39:47.061480197 +0000 UTC m=+152140.818615762: :ballot_box_with_check: agreed by crazycs520.
  • 2024-05-01 14:37:26.648292317 +0000 UTC m=+454400.405427889: :ballot_box_with_check: agreed by cfzjywxk.

ti-chi-bot[bot] avatar May 01 '24 14:05 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 06 '24 02:05 ti-chi-bot[bot]

/retest

Tema avatar May 06 '24 15:05 Tema