tidb icon indicating copy to clipboard operation
tidb copied to clipboard

fast_create_table: add retry and id_allocator

Open GMHDBJD opened this issue 1 year ago • 10 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/49752

Problem Summary:

What changed and how does it work?

  • add retry for retryable error
  • add id allocator to reduce write conflict

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

GMHDBJD avatar Apr 12 '24 06:04 GMHDBJD

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 12 '24 06:04 tiprow[bot]

/retest

GMHDBJD avatar Apr 15 '24 08:04 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 15 '24 08:04 tiprow[bot]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.2759%. Comparing base (49f1427) to head (91521cb). Report is 19 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52543         +/-   ##
=================================================
- Coverage   74.7101%   56.2759%   -18.4343%     
=================================================
  Files          1545       1669        +124     
  Lines        362047     612862     +250815     
=================================================
+ Hits         270486     344894      +74408     
- Misses        71923     244527     +172604     
- Partials      19638      23441       +3803     
Flag Coverage Δ
integration 37.2033% <0.0000%> (?)
unit 71.9354% <71.4285%> (-1.6858%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) :arrow_down:
parser ∅ <ø> (∅)
br 52.6914% <ø> (+5.0099%) :arrow_up:

codecov[bot] avatar Apr 15 '24 08:04 codecov[bot]

/retest

GMHDBJD avatar Apr 26 '24 06:04 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 26 '24 06:04 tiprow[bot]

/retest

GMHDBJD avatar Jul 01 '24 05:07 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 01 '24 05:07 tiprow[bot]

/retest

GMHDBJD avatar Jul 04 '24 16:07 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 04 '24 16:07 tiprow[bot]

/retest

GMHDBJD avatar Jul 05 '24 07:07 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 05 '24 07:07 tiprow[bot]

/retest

GMHDBJD avatar Jul 09 '24 09:07 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 09 '24 09:07 tiprow[bot]

/retest

GMHDBJD avatar Jul 09 '24 12:07 GMHDBJD

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jul 09 '24 12:07 tiprow[bot]

/ok-to-test

GMHDBJD avatar Jul 09 '24 13:07 GMHDBJD

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 10 '24 06:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 14:24:39.501462366 +0000 UTC m=+367576.736696479: :ballot_box_with_check: agreed by tangenta.
  • 2024-07-10 06:35:24.019274486 +0000 UTC m=+425821.254508598: :ballot_box_with_check: agreed by D3Hunter.

ti-chi-bot[bot] avatar Jul 10 '24 06:07 ti-chi-bot[bot]

/retest

GMHDBJD avatar Jul 10 '24 07:07 GMHDBJD

/retest

GMHDBJD avatar Jul 10 '24 09:07 GMHDBJD

/retest

GMHDBJD avatar Jul 10 '24 14:07 GMHDBJD

/retest

GMHDBJD avatar Jul 10 '24 14:07 GMHDBJD