tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: send backup request in batch

Open Leavrth opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: ref #52534

Problem Summary: The BackupRequest contains the key range of index or small partition, whose kv data is only distributed in few regions.

What changed and how does it work?

send backup request in batch.

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Leavrth avatar Apr 12 '24 04:04 Leavrth

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 12 '24 04:04 tiprow[bot]

Codecov Report

Attention: Patch coverage is 75.80645% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 74.3944%. Comparing base (b66a85c) to head (0bdd67e).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52535        +/-   ##
================================================
+ Coverage   72.0405%   74.3944%   +2.3539%     
================================================
  Files          1508       1514         +6     
  Lines        434733     455363     +20630     
================================================
+ Hits         313184     338765     +25581     
+ Misses       102012      95228      -6784     
- Partials      19537      21370      +1833     
Flag Coverage Δ
integration 29.5993% <72.9838%> (?)
unit 71.2276% <26.2096%> (-0.0219%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 55.8760% <75.8064%> (+17.5251%) :arrow_up:

codecov[bot] avatar Apr 15 '24 07:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 07 '24 03:05 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 09:48:35.518174416 +0000 UTC m=+264269.275309991: :ballot_box_with_check: agreed by 3pointer.
  • 2024-05-07 03:57:45.850342235 +0000 UTC m=+934419.607477808: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar May 07 '24 03:05 ti-chi-bot[bot]

/ok-to-test

Leavrth avatar May 07 '24 03:05 Leavrth

/retest

Leavrth avatar May 07 '24 04:05 Leavrth

/retest

Leavrth avatar May 07 '24 05:05 Leavrth