tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: remove unnecessary memory allocation in (*HashAggExec).initPartialWorkers

Open xzhangxian1008 opened this issue 10 months ago • 12 comments

What problem does this PR solve?

Issue Number: close #52321

Problem Summary:

What changed and how does it work?

no_optimization no optimization optimized optimization

no optimization flame graph optimization flame graph

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xzhangxian1008 avatar Apr 08 '24 13:04 xzhangxian1008

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Apr 08 '24 13:04 tiprow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.4476%. Comparing base (cfbabfa) to head (61ddc98). Report is 125 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52418        +/-   ##
================================================
+ Coverage   72.3769%   74.4476%   +2.0706%     
================================================
  Files          1474       1517        +43     
  Lines        427589     465159     +37570     
================================================
+ Hits         309476     346300     +36824     
- Misses        98890      98921        +31     
- Partials      19223      19938       +715     
Flag Coverage Δ
integration 48.6013% <100.0000%> (?)
unit 71.9969% <100.0000%> (+0.7368%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 36.5363% <ø> (-4.6730%) :arrow_down:

codecov[bot] avatar Apr 08 '24 13:04 codecov[bot]

/cc @XuHuaiyu @hawkingrei

xzhangxian1008 avatar Apr 11 '24 02:04 xzhangxian1008

@xzhangxian1008 Can you add some profiler to verify your improvement.

hawkingrei avatar Apr 11 '24 07:04 hawkingrei

/retest

hawkingrei avatar Apr 11 '24 07:04 hawkingrei

@xzhangxian1008 Can you add some profiler to verify your improvement.

ok

xzhangxian1008 avatar Apr 12 '24 05:04 xzhangxian1008

/cc @hawkingrei @XuHuaiyu

xzhangxian1008 avatar Apr 23 '24 03:04 xzhangxian1008

/cc @XuHuaiyu

xzhangxian1008 avatar Apr 26 '24 02:04 xzhangxian1008

/cc @XuHuaiyu

xzhangxian1008 avatar Apr 28 '24 05:04 xzhangxian1008

/cc @XuHuaiyu

xzhangxian1008 avatar Apr 29 '24 01:04 xzhangxian1008

/cc @XuHuaiyu

xzhangxian1008 avatar May 13 '24 01:05 xzhangxian1008

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [XuHuaiyu,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 13 '24 02:05 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-24 06:39:58.252263172 +0000 UTC m=+155954.992166081: :ballot_box_with_check: agreed by hawkingrei.
  • 2024-05-13 02:22:41.706961137 +0000 UTC m=+1447115.464096705: :ballot_box_with_check: agreed by XuHuaiyu.

ti-chi-bot[bot] avatar May 13 '24 02:05 ti-chi-bot[bot]

@xzhangxian1008: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 61ddc98561665ef5f3922c27578ad2024742d84b link true /test tidb_parser_test
fast_test_tiprow 61ddc98561665ef5f3922c27578ad2024742d84b link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar May 13 '24 02:05 tiprow[bot]