tidb icon indicating copy to clipboard operation
tidb copied to clipboard

statistics: remove one unused var

Open winoros opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

This var only has set-variable operations.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

winoros avatar Mar 31 '24 17:03 winoros

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 73.1065%. Comparing base (8d9e67b) to head (02070b2). :warning: Report is 3572 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52263        +/-   ##
================================================
+ Coverage   70.7570%   73.1065%   +2.3495%     
================================================
  Files          1491       1674       +183     
  Lines        440116     532918     +92802     
================================================
+ Hits         311413     389598     +78185     
- Misses       109272     120511     +11239     
- Partials      19431      22809      +3378     
Flag Coverage Δ
integration 54.2336% <ø> (?)
unit 73.3427% <ø> (+1.5866%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 67.5629% <ø> (+11.7106%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 31 '24 17:03 codecov[bot]

/retest

hawkingrei avatar Apr 01 '24 00:04 hawkingrei

/hold

hawkingrei avatar Apr 01 '24 01:04 hawkingrei

/retest

hawkingrei avatar Apr 01 '24 01:04 hawkingrei

/unhold

hawkingrei avatar Apr 01 '24 02:04 hawkingrei

/retest

hawkingrei avatar Apr 01 '24 03:04 hawkingrei

/retest

hawkingrei avatar Apr 11 '24 06:04 hawkingrei

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 11 '24 06:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 00:27:09.406175934 +0000 UTC m=+230890.933716482: :ballot_box_with_check: agreed by hawkingrei.
  • 2024-04-11 06:34:12.304061292 +0000 UTC m=+1116913.831601837: :ballot_box_with_check: agreed by hi-rustin.

ti-chi-bot[bot] avatar Apr 11 '24 06:04 ti-chi-bot[bot]

/retest

hawkingrei avatar May 28 '24 14:05 hawkingrei

@winoros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 02070b26cb13a60475a9117b5c5fa79196e3f5a5 link true /test check-dev2
pull-integration-realcluster-test-next-gen 02070b26cb13a60475a9117b5c5fa79196e3f5a5 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 02070b26cb13a60475a9117b5c5fa79196e3f5a5 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 16:09 ti-chi-bot[bot]