tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: fix function names in the comments

Open crazeteam opened this issue 1 year ago • 12 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

crazeteam avatar Mar 26 '24 06:03 crazeteam

CLA assistant check
All committers have signed the CLA.

sre-bot avatar Mar 26 '24 06:03 sre-bot

Hi @crazeteam. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 26 '24 06:03 ti-chi-bot[bot]

Hi @crazeteam. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Mar 26 '24 06:03 tiprow[bot]

PTAL @D3Hunter

zimulala avatar Mar 27 '24 01:03 zimulala

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance6716, zimulala Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 27 '24 01:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 01:40:39.547923382 +0000 UTC m=+2032066.570169770: :ballot_box_with_check: agreed by zimulala.
  • 2024-03-27 01:51:57.141841339 +0000 UTC m=+2032744.164087727: :ballot_box_with_check: agreed by lance6716.

ti-chi-bot[bot] avatar Mar 27 '24 01:03 ti-chi-bot[bot]

/cc @BornChanger

lance6716 avatar Mar 27 '24 01:03 lance6716

/ok-to-test

lance6716 avatar Mar 27 '24 01:03 lance6716

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.6229%. Comparing base (3475795) to head (fff72b3). Report is 1904 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52099         +/-   ##
=================================================
- Coverage   70.7242%   54.6229%   -16.1013%     
=================================================
  Files          1486       1599        +113     
  Lines        439452     610317     +170865     
=================================================
+ Hits         310799     333373      +22574     
- Misses       109205     253796     +144591     
- Partials      19448      23148       +3700     
Flag Coverage Δ
integration 36.6032% <ø> (?)
unit 70.4460% <ø> (-0.0977%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.1296% <ø> (+5.2846%) :arrow_up:

codecov[bot] avatar Mar 27 '24 02:03 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 08:03 ti-chi-bot[bot]

ptal @BornChanger

lance6716 avatar Mar 29 '24 08:03 lance6716

@crazeteam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test fff72b300068403867bec9ba5072e78e26728c6a link true /test pull-br-integration-test
pull-lightning-integration-test fff72b300068403867bec9ba5072e78e26728c6a link true /test pull-lightning-integration-test
pull-integration-e2e-test fff72b300068403867bec9ba5072e78e26728c6a link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Nov 18 '24 06:11 ti-chi-bot[bot]