tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor: Support TopN Spill

Open xzhangxian1008 opened this issue 11 months ago • 15 comments

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xzhangxian1008 avatar Mar 15 '24 05:03 xzhangxian1008

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Mar 15 '24 05:03 tiprow[bot]

Codecov Report

Attention: Patch coverage is 92.50399% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 71.2649%. Comparing base (acdb6f5) to head (7ac8f76). Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51809        +/-   ##
================================================
- Coverage   72.4943%   71.2649%   -1.2295%     
================================================
  Files          1493       1600       +107     
  Lines        429359     481892     +52533     
================================================
+ Hits         311261     343420     +32159     
- Misses        98889     117731     +18842     
- Partials      19209      20741      +1532     
Flag Coverage Δ
integration 48.9699% <34.1384%> (?)
unit 71.2749% <92.5925%> (-0.1220%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 27.4399% <ø> (-14.0171%) :arrow_down:

codecov[bot] avatar Mar 18 '24 10:03 codecov[bot]

/cc @SeaRise

SeaRise avatar Mar 28 '24 06:03 SeaRise

/cc @windtalker

xzhangxian1008 avatar Mar 28 '24 06:03 xzhangxian1008

/cc @SeaRise @windtalker

xzhangxian1008 avatar Apr 07 '24 02:04 xzhangxian1008

/cc @SeaRise @windtalker

xzhangxian1008 avatar Apr 08 '24 05:04 xzhangxian1008

/cc @windtalker

xzhangxian1008 avatar Apr 17 '24 03:04 xzhangxian1008

/cc @SeaRise @windtalker

xzhangxian1008 avatar Apr 18 '24 02:04 xzhangxian1008

/cc @SeaRise @windtalker

xzhangxian1008 avatar Apr 19 '24 01:04 xzhangxian1008

/hold

xzhangxian1008 avatar Apr 19 '24 05:04 xzhangxian1008

/cc @SeaRise @windtalker

xzhangxian1008 avatar Apr 22 '24 01:04 xzhangxian1008

@SeaRise: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 22 '24 06:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 30 '24 05:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 05:28:48.313705992 +0000 UTC m=+575147.424752441: :ballot_box_with_check: agreed by SeaRise.
  • 2024-04-30 05:59:13.027222415 +0000 UTC m=+336906.784357988: :ballot_box_with_check: agreed by windtalker.

ti-chi-bot[bot] avatar Apr 30 '24 05:04 ti-chi-bot[bot]

/retest

xzhangxian1008 avatar May 11 '24 08:05 xzhangxian1008

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 11 '24 08:05 tiprow[bot]

/retest

xzhangxian1008 avatar May 13 '24 01:05 xzhangxian1008

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 13 '24 01:05 tiprow[bot]

/retest

xzhangxian1008 avatar May 13 '24 06:05 xzhangxian1008

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 13 '24 06:05 tiprow[bot]

@xzhangxian1008: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test a2996459d02bd09d85e7a6f12e3ced3efcb268e3 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar May 13 '24 07:05 ti-chi-bot[bot]

/unhold

xzhangxian1008 avatar May 14 '24 02:05 xzhangxian1008

/retest

xzhangxian1008 avatar May 14 '24 07:05 xzhangxian1008

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar May 14 '24 07:05 tiprow[bot]