tidb
tidb copied to clipboard
*: set timeout for PD HTTP client
What problem does this PR solve?
Issue Number: ref #49865
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, yujuncen for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @CabinfeverB. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #51286 (be816a3) into master (625eded) will increase coverage by
2.2093%. Report is 483 commits behind head on master. The diff coverage is58.0645%.
Additional details and impacted files
@@ Coverage Diff @@
## master #51286 +/- ##
================================================
+ Coverage 70.5955% 72.8049% +2.2093%
================================================
Files 1459 1460 +1
Lines 434196 437388 +3192
================================================
+ Hits 306523 318440 +11917
+ Misses 108383 98971 -9412
- Partials 19290 19977 +687
| Flag | Coverage Δ | |
|---|---|---|
| integration | 48.9054% <60.0000%> (?) |
|
| unit | 70.3440% <54.8387%> (-0.0385%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 53.9957% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 51.3136% <14.2857%> (+5.4556%) |
:arrow_up: |
/ok-to-test
/test build
@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test tidb_parser_test/test tiprow_fast_test
Use /test all to run all jobs.
In response to this:
/test build
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.
For example:
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@CabinfeverB: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| idc-jenkins-ci-tidb/build | be816a3982375725f100352ccd1d1e51a4130b2c | link | true | /test build |
| pull-lightning-integration-test | be816a3982375725f100352ccd1d1e51a4130b2c | link | true | /test pull-lightning-integration-test |
| pull-br-integration-test | be816a3982375725f100352ccd1d1e51a4130b2c | link | true | /test pull-br-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.