tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: force the new upgrading tidb to be owner

Open wjhuang2016 opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close #51269

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

wjhuang2016 avatar Feb 23 '24 09:02 wjhuang2016

Codecov Report

Attention: Patch coverage is 18.57143% with 57 lines in your changes missing coverage. Please review.

Project coverage is 70.2804%. Comparing base (801d5d6) to head (ae88394). Report is 75 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51285        +/-   ##
================================================
- Coverage   72.8365%   70.2804%   -2.5562%     
================================================
  Files          1564       1707       +143     
  Lines        439076     560866    +121790     
================================================
+ Hits         319808     394179     +74371     
- Misses        99580     143972     +44392     
- Partials      19688      22715      +3027     
Flag Coverage Δ
integration 49.4966% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (+1.0390%) :arrow_up:
parser ∅ <ø> (∅)
br 45.0633% <ø> (-0.8167%) :arrow_down:

codecov[bot] avatar Feb 23 '24 10:02 codecov[bot]

/retest

wjhuang2016 avatar Feb 27 '24 09:02 wjhuang2016

/retest

wjhuang2016 avatar Feb 27 '24 12:02 wjhuang2016

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from wjhuang2016 and additionally assign yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 05 '24 08:08 ti-chi-bot[bot]

@wjhuang2016: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow ae883946c732aee01474224e41fa8dffe801f1f0 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tiprow[bot] avatar Aug 05 '24 09:08 tiprow[bot]

@wjhuang2016: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 5471b05532cfa3b160f0361b9182ee31d5cf07d3 link true /test pull-br-integration-test
pull-lightning-integration-test 5471b05532cfa3b160f0361b9182ee31d5cf07d3 link true /test pull-lightning-integration-test
idc-jenkins-ci-tidb/unit-test ae883946c732aee01474224e41fa8dffe801f1f0 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Aug 05 '24 09:08 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Aug 12 '24 04:08 ti-chi-bot[bot]