tidb
tidb copied to clipboard
[WIP]*: save a TS when engine is closed and use it as startTS when ingest
What problem does this PR solve?
Issue Number: close #46986
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @lance6716. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #51283 (5302b8e) into master (a6768bc) will decrease coverage by
15.5867%
. Report is 3 commits behind head on master. The diff coverage is65.5737%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #51283 +/- ##
=================================================
- Coverage 70.5513% 54.9646% -15.5867%
=================================================
Files 1459 1571 +112
Lines 434196 604028 +169832
=================================================
+ Hits 306331 332002 +25671
- Misses 108552 248852 +140300
- Partials 19313 23174 +3861
Flag | Coverage Δ | |
---|---|---|
integration | 37.7872% <65.5737%> (?) |
|
unit | 70.3132% <13.1147%> (-0.0067%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
dumpling | 53.9957% <ø> (ø) |
|
parser | ∅ <ø> (∅) |
|
br | 56.5798% <54.1666%> (+10.7652%) |
:arrow_up: |
/ok-to-test
/test pull-lightning-integration-test
@D3Hunter: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
-
/test tidb_parser_test
-
/test tiprow_fast_test
Use /test all
to run all jobs.
In response to this:
/test pull-lightning-integration-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@lance6716: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
idc-jenkins-ci-tidb/build | 5302b8eb4f97f7f2873fb3efda0b3b07444fdd5e | link | true | /test build |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
lightning CI passed https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/67/pipeline
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: D3Hunter, tangenta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [D3Hunter,tangenta]
- ~~br/pkg/lightning/OWNERS~~ [D3Hunter]
- ~~pkg/ddl/OWNERS~~ [tangenta]
- ~~pkg/disttask/OWNERS~~ [D3Hunter,tangenta]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
change target branch because kvproto PR will not be merged soon