br: split in each TiKV and wait scatter at last

[Leavrth]

trafficstars

What problem does this PR solve?

Issue Number: close #50665

Problem Summary: the new split & scatter method has some bugs with checkpoint restore.

What changed and how does it work?

We found we can use the original function to implement it, so remove these unstable functinos.

Check List

Tests

• [x] Unit test
• [x] Integration test
• [x] Manual test (add detailed scripts or steps below)

• [ ] No need to test

  • [ ] I checked and no code files have been changed.

Side effects

• [ ] Performance regression: Consumes more CPU
• [ ] Performance regression: Consumes more Memory
• [ ] Breaking backward compatibility

Documentation

• [ ] Affects user behaviors
• [ ] Contains syntax changes
• [ ] Contains variable changes
• [ ] Contains experimental features
• [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow[bot]]

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov[bot]]

Codecov Report

Merging #51281 (e38bfb6) into master (20ffdd1) will increase coverage by 3.2023%. Report is 116 commits behind head on master. The diff coverage is 76.8115%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51281        +/-   ##
================================================
+ Coverage   70.5965%   73.7988%   +3.2023%     
================================================
  Files          1468       1476         +8     
  Lines        435149     456006     +20857     
================================================
+ Hits         307200     336527     +29327     
+ Misses       108678      98795      -9883     
- Partials      19271      20684      +1413     

Flag	Coverage Δ
integration	50.3803% <72.4637%> (?)
unit	70.8502% <71.0144%> (+0.4539%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	55.7771% <76.8115%> (+9.8928%)	:arrow_up:

[Leavrth]

/test pull-br-integration-test

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/test pull-br-integration-test

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/test pull-br-integration-test

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~br/OWNERS~~ [3pointer,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot[bot]]

[LGTM Timeline notifier]

Timeline:

• 2024-03-04 09:44:03.361736121 +0000 UTC m=+73870.383982510: :ballot_box_with_check: agreed by 3pointer.
• 2024-03-05 03:58:28.894562251 +0000 UTC m=+139535.916808639: :ballot_box_with_check: agreed by YuJuncen.

[Leavrth]

/retest

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/test pull-br-integration-test

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/test pull-br-integration-test

[tiprow[bot]]

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/ok-to-test

[Leavrth]

/retest

[tiprow[bot]]

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	e38bfb6f88610c60c3b993f2fdd1ebee1e88777b	link	true	/test fast_test_tiprow
tidb_parser_test	e38bfb6f88610c60c3b993f2fdd1ebee1e88777b	link	true	/test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.