tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: data type default values support `STR_TO_DATE('1980-01-01','%Y-%m-%d')`

Open zimulala opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/51276

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

zimulala avatar Feb 23 '24 06:02 zimulala

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 23 '24 06:02 tiprow[bot]

Codecov Report

Merging #51278 (a8b5905) into master (f4e758a) will increase coverage by 2.1322%. Report is 2 commits behind head on master. The diff coverage is 62.5000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51278        +/-   ##
================================================
+ Coverage   70.6793%   72.8116%   +2.1322%     
================================================
  Files          1460       1460                
  Lines        434615     435193       +578     
================================================
+ Hits         307183     316871      +9688     
+ Misses       108242      98410      -9832     
- Partials      19190      19912       +722     
Flag Coverage Δ
integration 48.9854% <12.5000%> (?)
unit 70.4292% <62.5000%> (-0.0453%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4077% <ø> (+5.5239%) :arrow_up:

codecov[bot] avatar Feb 23 '24 08:02 codecov[bot]

UT failed because encountered this issue: https://github.com/pingcap/tidb/issues/51289.

zimulala avatar Feb 26 '24 03:02 zimulala

/retest-required

zimulala avatar Feb 26 '24 03:02 zimulala

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 26 '24 03:02 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 03:01:35.718142869 +0000 UTC m=+844584.465765979: :ballot_box_with_check: agreed by Defined2014.
  • 2024-02-26 07:45:49.728181463 +0000 UTC m=+861638.475804575: :ballot_box_with_check: agreed by CbcWestwolf.

ti-chi-bot[bot] avatar Feb 26 '24 07:02 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 10:02 ti-chi-bot[bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #51453.

ti-chi-bot avatar Mar 01 '24 08:03 ti-chi-bot