tidb icon indicating copy to clipboard operation
tidb copied to clipboard

disttask/ddl: add log for add index operators

Open ywqzzy opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: ref #48779

Problem Summary:

What changed and how does it work?

Add some log for easier debugging.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ywqzzy avatar Feb 23 '24 05:02 ywqzzy

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 23 '24 05:02 tiprow[bot]

Codecov Report

Merging #51267 (5ea993e) into master (f0a26dd) will decrease coverage by 15.3569%. Report is 94 commits behind head on master. The diff coverage is 80.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51267         +/-   ##
=================================================
- Coverage   70.5842%   55.2273%   -15.3570%     
=================================================
  Files          1467       1582        +115     
  Lines        434825     627669     +192844     
=================================================
+ Hits         306918     346645      +39727     
- Misses       108672     256986     +148314     
- Partials      19235      24038       +4803     
Flag Coverage Δ
integration 37.0404% <80.0000%> (?)
unit 70.4488% <0.0000%> (+0.0517%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2644% <ø> (-0.0297%) :arrow_down:
parser ∅ <ø> (∅)
br 49.8113% <ø> (+4.0662%) :arrow_up:

codecov[bot] avatar Feb 23 '24 05:02 codecov[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 07:26:22.355512307 +0000 UTC m=+601271.103135439: :ballot_box_with_check: agreed by lance6716.
  • 2024-02-26 07:31:11.3985013 +0000 UTC m=+860760.146124396: :ballot_box_with_check: agreed by D3Hunter.

ti-chi-bot[bot] avatar Feb 26 '24 07:02 ti-chi-bot[bot]

/approve

ywqzzy avatar Feb 26 '24 08:02 ywqzzy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 08:02 ti-chi-bot[bot]

/retest

ywqzzy avatar Feb 26 '24 08:02 ywqzzy

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 26 '24 08:02 tiprow[bot]