tidb
tidb copied to clipboard
[WIP]ddl: let tidb_ddl_reorg_worker_cnt controls fast DDL concurrency
What problem does this PR solve?
Issue Number: ref #51272
Problem Summary:
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @lance6716. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #51261 (204a211) into master (5b187e5) will decrease coverage by
14.9375%. Report is 32 commits behind head on master. The diff coverage is66.6666%.
Additional details and impacted files
@@ Coverage Diff @@
## master #51261 +/- ##
=================================================
- Coverage 70.7007% 55.7633% -14.9375%
=================================================
Files 1457 1571 +114
Lines 433745 611409 +177664
=================================================
+ Hits 306661 340942 +34281
- Misses 107895 247586 +139691
- Partials 19189 22881 +3692
| Flag | Coverage Δ | |
|---|---|---|
| integration | 37.9381% <66.6666%> (?) |
|
| unit | 71.3317% <0.0000%> (+0.8359%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 53.9957% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 51.5811% <ø> (+5.7045%) |
:arrow_up: |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tangenta, ywqzzy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/ddl/OWNERS~~ [tangenta,ywqzzy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
/retest
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.