tidb icon indicating copy to clipboard operation
tidb copied to clipboard

log: Support a dedicated log file to save general log

Open Defined2014 opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: ref #51248

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Defined2014 avatar Feb 22 '24 09:02 Defined2014

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 22 '24 09:02 tiprow[bot]

/retest

Defined2014 avatar Feb 22 '24 09:02 Defined2014

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 22 '24 09:02 tiprow[bot]

Codecov Report

Merging #51249 (c37deda) into master (0d742d3) will increase coverage by 0.3021%. Report is 11 commits behind head on master. The diff coverage is 78.8617%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51249        +/-   ##
================================================
+ Coverage   72.4732%   72.7753%   +0.3021%     
================================================
  Files          1475       1476         +1     
  Lines        363671     439513     +75842     
================================================
+ Hits         263564     319857     +56293     
- Misses        80719      99671     +18952     
- Partials      19388      19985       +597     
Flag Coverage Δ
integration 48.8822% <27.6422%> (?)
unit 70.6041% <78.8617%> (-1.7596%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) :arrow_down:
parser ∅ <ø> (∅)
br 50.9619% <ø> (+4.5526%) :arrow_up:

codecov[bot] avatar Feb 22 '24 09:02 codecov[bot]

/test check-dev2

Defined2014 avatar Mar 12 '24 08:03 Defined2014

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Mar 12 '24 08:03 tiprow[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 11:08:22.313344569 +0000 UTC m=+770129.335590958: :ballot_box_with_check: agreed by xhebox.
  • 2024-03-13 03:58:18.686288422 +0000 UTC m=+830725.708534809: :ballot_box_with_check: agreed by tiancaiamao.

ti-chi-bot[bot] avatar Mar 13 '24 03:03 ti-chi-bot[bot]

/approve

easonn7 avatar Mar 14 '24 02:03 easonn7

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, tiancaiamao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 14 '24 02:03 ti-chi-bot[bot]