tidb
tidb copied to clipboard
pitr: support log backup to s3 when object lock is enabled
What problem does this PR solve?
Issue Number: close #51184
Problem Summary:
What changed and how does it work?
Set the ExternalStorageOptions.CheckS3ObjectLockOptions
True to add content-MD5 in header when start logbackup.
Check List
Tests
- [x] Manual test (add detailed scripts or steps below)
see #13350
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Fix the issue that when repentant time is enabled in aws s3, log backup will cause error: “HTTP header is required for Put Object requests with Object Lock parameters”
Hi @RidRisR. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #51210 (68fed8d) into master (0545066) will decrease coverage by
16.1634%
. Report is 64 commits behind head on master. The diff coverage is0.0000%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #51210 +/- ##
=================================================
- Coverage 70.6306% 54.4673% -16.1634%
=================================================
Files 1467 1583 +116
Lines 434879 620091 +185212
=================================================
+ Hits 307158 337747 +30589
- Misses 108514 259007 +150493
- Partials 19207 23337 +4130
Flag | Coverage Δ | |
---|---|---|
integration | 36.9655% <0.0000%> (?) |
|
unit | 70.5789% <0.0000%> (+0.1463%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
dumpling | 53.9957% <ø> (ø) |
|
parser | ∅ <ø> (∅) |
|
br | 51.5369% <0.0000%> (+5.6255%) |
:arrow_up: |
/test all
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
In response to this:
/test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Leavrth, YuJuncen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~br/OWNERS~~ [Leavrth,YuJuncen]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment