tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: add privilege check for admin commands

Open okJiang opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/51183

Problem Summary:

  • as title

What changed and how does it work?

  • as title

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

okJiang avatar Feb 20 '24 07:02 okJiang

Codecov Report

Merging #51185 (529924c) into master (b7ce239) will increase coverage by 2.0794%. Report is 139 commits behind head on master. The diff coverage is 75.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51185        +/-   ##
================================================
+ Coverage   70.5182%   72.5977%   +2.0794%     
================================================
  Files          1466       1475         +9     
  Lines        434123     457166     +23043     
================================================
+ Hits         306136     331892     +25756     
+ Misses       108739     104840      -3899     
- Partials      19248      20434      +1186     
Flag Coverage Δ
integration 48.9655% <75.0000%> (?)
unit 70.3533% <75.0000%> (+0.0274%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2644% <ø> (-0.0297%) :arrow_down:
parser ∅ <ø> (∅)
br 49.4604% <ø> (+3.7275%) :arrow_up:

codecov[bot] avatar Feb 20 '24 07:02 codecov[bot]

/cc @tangenta @asddongmen @GMHDBJD

okJiang avatar Feb 26 '24 02:02 okJiang

@okJiang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test ba1bfd4481fb876efa2fd720e1f467b4d9bee2aa link true /test fast_test_tiprow
tidb_parser_test 529924c98b482979bfa8701fff55da2030d8a6b3 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Feb 27 '24 09:02 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [GMHDBJD,tangenta]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 27 '24 09:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 09:31:37.317257234 +0000 UTC m=+954386.064880344: :ballot_box_with_check: agreed by tangenta.
  • 2024-02-27 09:49:06.926142006 +0000 UTC m=+955435.673765118: :ballot_box_with_check: agreed by GMHDBJD.

ti-chi-bot[bot] avatar Feb 27 '24 09:02 ti-chi-bot[bot]