tidb
tidb copied to clipboard
parser, ddl: data type default values support `DATE_FORMAT(NOW(),'%Y-%m...')`
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tidb/issues/51031
Problem Summary:
- Data type default values support
DATE_FORMAT(NOW(),'%Y-%m...')
What changed and how does it work?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Hi @zimulala. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #51076 (e3986d7) into master (9ee46d4) will decrease coverage by
15.8854%
. Report is 24 commits behind head on master. The diff coverage is59.3750%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #51076 +/- ##
=================================================
- Coverage 70.5917% 54.7064% -15.8854%
=================================================
Files 1467 1582 +115
Lines 435011 610689 +175678
=================================================
+ Hits 307082 334086 +27004
- Misses 108658 253479 +144821
- Partials 19271 23124 +3853
Flag | Coverage Δ | |
---|---|---|
integration | 36.6890% <18.7500%> (?) |
|
unit | 70.3218% <50.0000%> (-0.0689%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
dumpling | 54.0825% <ø> (+0.0868%) |
:arrow_up: |
parser | ∅ <ø> (∅) |
|
br | 51.1584% <ø> (+5.2703%) |
:arrow_up: |
PTAL @tangenta @CbcWestwolf
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CbcWestwolf, tangenta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/ddl/OWNERS~~ [tangenta]
- ~~pkg/parser/OWNERS~~ [tangenta]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-02-26 07:36:52.566061265 +0000 UTC m=+861101.313684380
: :ballot_box_with_check: agreed by CbcWestwolf. -
2024-02-26 10:19:04.613647306 +0000 UTC m=+870833.361270433
: :ballot_box_with_check: agreed by tangenta.
@zimulala: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
tiprow_fast_test | e3986d7028aa08924473bf61c630e1b648d791e2 | link | true | /test tiprow_fast_test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.