tidb icon indicating copy to clipboard operation
tidb copied to clipboard

disttask: refine manager retry

Open ywqzzy opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

Use handle.RunWithRetry

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ywqzzy avatar Feb 08 '24 03:02 ywqzzy

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 08 '24 03:02 tiprow[bot]

Codecov Report

Merging #51071 (d943d2c) into master (f0a26dd) will decrease coverage by 15.4425%. Report is 96 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51071         +/-   ##
=================================================
- Coverage   70.5842%   55.1418%   -15.4425%     
=================================================
  Files          1467       1583        +116     
  Lines        434825     629323     +194498     
=================================================
+ Hits         306918     347020      +40102     
- Misses       108672     258210     +149538     
- Partials      19235      24093       +4858     
Flag Coverage Δ
integration 37.1942% <33.3333%> (?)
unit 70.3229% <90.4761%> (-0.0742%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2644% <ø> (-0.0297%) :arrow_down:
parser ∅ <ø> (∅)
br 49.7539% <ø> (+4.0087%) :arrow_up:

codecov[bot] avatar Feb 08 '24 03:02 codecov[bot]

/retest

ywqzzy avatar Feb 23 '24 07:02 ywqzzy

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 23 '24 07:02 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 10:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 07:44:40.92556931 +0000 UTC m=+602369.673192422: :ballot_box_with_check: agreed by D3Hunter.
  • 2024-02-26 10:18:56.896411415 +0000 UTC m=+870825.644034526: :ballot_box_with_check: agreed by okJiang.

ti-chi-bot[bot] avatar Feb 26 '24 10:02 ti-chi-bot[bot]