tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br/streamhelper: fix panic while removing task (#50869)

Open ti-chi-bot opened this issue 1 year ago • 4 comments

This is an automated cherry-pick of #50869

What problem does this PR solve?

Issue Number: close #50839

Problem Summary:

What changed and how does it work?

This PR will do the nil check over the checkpoints. This PR also will catch the panic generated during the subscription handler. And some locking are acquired during handling incoming tasks.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may make TiDB panic when stopping a log backup task.

ti-chi-bot avatar Feb 07 '24 09:02 ti-chi-bot

/retest

BornChanger avatar Feb 23 '24 07:02 BornChanger

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 11 '24 08:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 07:08:49.31913935 +0000 UTC m=+600218.066762461: :ballot_box_with_check: agreed by BornChanger.
  • 2024-03-11 08:15:04.810008654 +0000 UTC m=+673331.832255043: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar Mar 11 '24 08:03 ti-chi-bot[bot]

/retest-required

YuJuncen avatar Mar 12 '24 06:03 YuJuncen