tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: rename tidb_ddl_version to tidb_enable_fast_create_table

Open GMHDBJD opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close #50052

Problem Summary:

What changed and how does it work?

  • rename tidb_ddl_version to tidb_enable_fast_create_table

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

GMHDBJD avatar Feb 07 '24 08:02 GMHDBJD

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 07 '24 08:02 tiprow[bot]

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.2251%. Comparing base (671e980) to head (cd768ac). Report is 1451 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51047        +/-   ##
================================================
+ Coverage   70.5709%   73.2251%   +2.6542%     
================================================
  Files          1468       1476         +8     
  Lines        435148     448477     +13329     
================================================
+ Hits         307088     328398     +21310     
+ Misses       108762     100067      -8695     
- Partials      19298      20012       +714     
Flag Coverage Δ
integration 49.8511% <23.0769%> (?)
unit 70.9058% <84.6153%> (+0.5490%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.0313% <ø> (+5.1557%) :arrow_up:

codecov[bot] avatar Feb 07 '24 09:02 codecov[bot]

What about the naming like addBatchDDLJobsV2?

tangenta avatar Feb 23 '24 06:02 tangenta

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 08:52:06.444047375 +0000 UTC m=+952015.191670486: :ballot_box_with_check: agreed by tangenta.
  • 2024-02-27 12:21:56.357745677 +0000 UTC m=+964605.105368787: :ballot_box_with_check: agreed by zimulala.

ti-chi-bot[bot] avatar Feb 27 '24 12:02 ti-chi-bot[bot]

/approve

easonn7 avatar Feb 28 '24 07:02 easonn7

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 28 '24 07:02 ti-chi-bot[bot]