tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: create database by db pool (#50771)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #50771

What problem does this PR solve?

Issue Number: close #50767

Problem Summary: br restore is very slowly if there are many databases(2000+)

What changed and how does it work?

create database by db pool

Check List

Tests

  • [x] Unit test
  • [x] Integration test
  • [x] Manual test (add detailed scripts or steps below)

40 minutes -> 5 minutes

  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Feb 07 '24 03:02 ti-chi-bot

/retest

Leavrth avatar Mar 27 '24 09:03 Leavrth

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Leavrth,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 27 '24 10:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 10:25:18.925684068 +0000 UTC m=+2063545.947930457: :ballot_box_with_check: agreed by YuJuncen.
  • 2024-03-27 10:27:55.937445645 +0000 UTC m=+2063702.959692033: :ballot_box_with_check: agreed by Leavrth.

ti-chi-bot[bot] avatar Mar 27 '24 10:03 ti-chi-bot[bot]

/hold

Leavrth avatar Mar 27 '24 10:03 Leavrth

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-6.5@2ec7e32). Click here to learn what that means. The diff coverage is 56.5217%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51026   +/-   ##
================================================
  Coverage               ?   73.6546%           
================================================
  Files                  ?       1095           
  Lines                  ?     350946           
  Branches               ?          0           
================================================
  Hits                   ?     258488           
  Misses                 ?      75855           
  Partials               ?      16603           

codecov[bot] avatar Mar 27 '24 10:03 codecov[bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 27 '24 10:03 ti-chi-bot[bot]