tidb
tidb copied to clipboard
disttask: remove onError
What problem does this PR solve?
Issue Number: ref #49008
Problem Summary:
What changed and how does it work?
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from ywqzzy. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @ywqzzy. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Attention: Patch coverage is 77.46479%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 55.0741%. Comparing base (
9ee46d4
) to head (39a7a4e
). Report is 1366 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #51003 +/- ##
=================================================
- Coverage 70.5917% 55.0741% -15.5177%
=================================================
Files 1467 1577 +110
Lines 435011 610056 +175045
=================================================
+ Hits 307082 335983 +28901
- Misses 108658 250887 +142229
- Partials 19271 23186 +3915
Flag | Coverage Δ | |
---|---|---|
integration | 36.6658% <49.2957%> (?) |
|
unit | 70.3155% <76.0563%> (-0.0752%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
dumpling | 54.0825% <ø> (+0.0868%) |
:arrow_up: |
parser | ∅ <ø> (∅) |
|
br | 51.3194% <ø> (+5.4313%) |
:arrow_up: |
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@ywqzzy: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-br-integration-test | 39a7a4ecb41793c34d2e465a3a574d548dbe81e0 | link | true | /test pull-br-integration-test |
pull-lightning-integration-test | 39a7a4ecb41793c34d2e465a3a574d548dbe81e0 | link | true | /test pull-lightning-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.