tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: make log command visible in cli

Open RidRisR opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: close #50927

Problem Summary:

The command was set hidden, now it has been set visible.

What changed and how does it work?

Check List

Tests

  • [x] Manual test (add detailed scripts or steps below) image

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Now the candidate command "log" in br is visible in help.

RidRisR avatar Feb 06 '24 00:02 RidRisR

CLA assistant check
All committers have signed the CLA.

sre-bot avatar Feb 06 '24 00:02 sre-bot

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 06 '24 00:02 tiprow[bot]

Codecov Report

Merging #50995 (47abeea) into master (e528b68) will increase coverage by 1.5113%. Report is 161 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50995        +/-   ##
================================================
+ Coverage   72.3482%   73.8596%   +1.5113%     
================================================
  Files          1466       1467         +1     
  Lines        361728     446355     +84627     
================================================
+ Hits         261704     329676     +67972     
- Misses        80781      96944     +16163     
- Partials      19243      19735       +492     
Flag Coverage Δ
integration 50.8505% <ø> (?)
unit 71.5944% <100.0000%> (-0.6410%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (-2.1832%) :arrow_down:
parser ∅ <ø> (∅)
br 51.9787% <100.0000%> (+5.6706%) :arrow_up:

codecov[bot] avatar Feb 06 '24 01:02 codecov[bot]

@RidRisR please paste your screen shots of your manual testing and also fill the release notes.

BornChanger avatar Feb 19 '24 06:02 BornChanger

/component br

BornChanger avatar Feb 19 '24 09:02 BornChanger

@RidRisR please paste your screen shots of your manual testing and also fill the release notes.

@RidRisR please paste your screen shots of your manual testing and also fill the release notes.

done

RidRisR avatar Feb 21 '24 01:02 RidRisR

/label affects-6.5

BornChanger avatar Feb 22 '24 09:02 BornChanger

/label affects-7.1

BornChanger avatar Feb 22 '24 09:02 BornChanger

/label affects-7.5

BornChanger avatar Feb 22 '24 09:02 BornChanger

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 01 '24 03:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 09:47:03.512314715 +0000 UTC m=+523312.259937811: :ballot_box_with_check: agreed by BornChanger.
  • 2024-03-01 03:47:29.311405621 +0000 UTC m=+1192938.059028733: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar Mar 01 '24 03:03 ti-chi-bot[bot]

@RidRisR: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 47abeea0e7370d96f8ca629845dd2a2e9c5b8303 link true /test tidb_parser_test
fast_test_tiprow 47abeea0e7370d96f8ca629845dd2a2e9c5b8303 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Mar 01 '24 04:03 tiprow[bot]