tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: remove useless tiflash config under br testing

Open JaySon-Huang opened this issue 1 year ago • 23 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

There are many useless tiflash config item. Some of them are need in the very begin, but they are optional after some version. Sometime they make the integration test fail.

What changed and how does it work?

  • Remove all useless tiflash config under br testing, avoid they make the integration test fail oneday
  • Fix the http URL for detecting tiflash is UP

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

JaySon-Huang avatar Feb 05 '24 09:02 JaySon-Huang

Hi @JaySon-Huang. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 05 '24 09:02 tiprow[bot]

Codecov Report

Merging #50986 (76aab9a) into master (4c76b12) will decrease coverage by 13.7660%. Report is 87 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50986         +/-   ##
=================================================
- Coverage   70.5887%   56.8228%   -13.7660%     
=================================================
  Files          1467       1585        +118     
  Lines        434905     623158     +188253     
=================================================
+ Hits         306994     354096      +47102     
- Misses       108649     246340     +137691     
- Partials      19262      22722       +3460     
Flag Coverage Δ
integration 37.8593% <ø> (?)
unit 72.4618% <ø> (+2.0769%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 52.1076% <ø> (+6.2396%) :arrow_up:

codecov[bot] avatar Feb 05 '24 10:02 codecov[bot]

/test pull-lightning-integration-test

lance6716 avatar Feb 05 '24 13:02 lance6716

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 05 '24 13:02 tiprow[bot]

/test pull-br-integration-test

YangKeao avatar Feb 05 '24 14:02 YangKeao

@YangKeao: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 05 '24 14:02 tiprow[bot]

TiFlash is still failed to start (and in BR/lightning integration tests we have ignored this error)

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_lightning_integration_test/detail/pull_lightning_integration_test/40/pipeline/196

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

TiFlash seems doesn't started, retrying...

failed to start tiflash

selected test cases: lightning_auto_random_default

lance6716 avatar Feb 05 '24 14:02 lance6716

@lance6716 how can I check the tiflash's logging in the failure tests? Or how to run the test locally?

JaySon-Huang avatar Feb 06 '24 03:02 JaySon-Huang

@lance6716 how can I check the tiflash's logging in the failure tests? Or how to run the test locally?

@JaySon-Huang You can click the Artifacts and download log-G00.tar.gz on CI pages, which usually contains the tiflash log in failed tests 🤔 .

YangKeao avatar Feb 06 '24 04:02 YangKeao

/test pull-br-integration-test

JaySon-Huang avatar Feb 06 '24 04:02 JaySon-Huang

@JaySon-Huang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 06 '24 04:02 tiprow[bot]

@YangKeao @lance6716 please help to trigger the test and check whether it is fixed by the latest commit ❤️

JaySon-Huang avatar Feb 06 '24 04:02 JaySon-Huang

/test pull-lightning-integration-test

lance6716 avatar Feb 06 '24 04:02 lance6716

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 06 '24 04:02 tiprow[bot]

/retest

JaySon-Huang avatar Feb 06 '24 05:02 JaySon-Huang

@JaySon-Huang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 06 '24 05:02 tiprow[bot]

/cc @3pointer

lance6716 avatar Feb 06 '24 06:02 lance6716

@JaySon-Huang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test b0fa47682e91da76f4eca6b117a3e2e042a13170 link false /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Feb 21 '24 07:02 ti-chi-bot[bot]

/retest

JaySon-Huang avatar Feb 21 '24 11:02 JaySon-Huang

@JaySon-Huang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 21 '24 11:02 tiprow[bot]

@BornChanger @3pointer PTAL~

JaySon-Huang avatar Feb 22 '24 06:02 JaySon-Huang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 29 '24 13:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 05:52:37.238299086 +0000 UTC m=+249682.805068961: :ballot_box_with_check: agreed by lance6716.
  • 2024-02-29 13:23:50.007338665 +0000 UTC m=+1141118.754961775: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar Feb 29 '24 13:02 ti-chi-bot[bot]

@JaySon-Huang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 76aab9a0832fefe1be62bf89dfa6afce88dc2d23 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Feb 29 '24 13:02 tiprow[bot]