tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: fix incorrect tableDual plan caused by comparing year with big value

Open hawkingrei opened this issue 1 year ago • 4 comments
trafficstars

What problem does this PR solve?

Issue Number: close #50235

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei avatar Feb 04 '24 03:02 hawkingrei

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 04 '24 03:02 ti-chi-bot[bot]

Codecov Report

Merging #50947 (70b823c) into master (15a8459) will decrease coverage by 16.4058%. Report is 450 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50947         +/-   ##
=================================================
- Coverage   70.6430%   54.2373%   -16.4058%     
=================================================
  Files          1459       1568        +109     
  Lines        434200     602989     +168789     
=================================================
+ Hits         306732     327045      +20313     
- Misses       108243     253038     +144795     
- Partials      19225      22906       +3681     
Flag Coverage Δ
integration 21.9345% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3686% <ø> (+5.4941%) :arrow_up:

codecov[bot] avatar Feb 06 '24 04:02 codecov[bot]

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Feb 27 '24 10:02 tiprow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 08:03 ti-chi-bot[bot]

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test unit-test
pull-mysql-client-test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test check-dev2
pull-br-integration-test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test pull-br-integration-test
pull-lightning-integration-test 70b823c2b01e510d5e10c2f22c0e800ef3282ed3 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 10 '24 07:04 ti-chi-bot[bot]