session,executor: get back the error stack information from a regression

[tiancaiamao]

trafficstars

What problem does this PR solve?

Issue Number: close #50849

Problem Summary:

What changed and how does it work?

The standard errors.Join(err1, err2) turn the error into another kind, losing the error stack information. Avoid using this API.

Check List

Tests

• [X] Unit test
• [ ] Integration test
• [ ] Manual test (add detailed scripts or steps below)
• [ ] No need to test

  • [ ] I checked and no code files have been changed.

Side effects

• [ ] Performance regression: Consumes more CPU
• [ ] Performance regression: Consumes more Memory
• [ ] Breaking backward compatibility

Documentation

• [ ] Affects user behaviors
• [ ] Contains syntax changes
• [ ] Contains variable changes
• [ ] Contains experimental features
• [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow[bot]]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov[bot]]

Codecov Report

Merging #50857 (0f563bf) into master (c76fe3f) will decrease coverage by 12.4712%. Report is 175 commits behind head on master. The diff coverage is 100.0000%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50857         +/-   ##
=================================================
- Coverage   70.5619%   58.0908%   -12.4712%     
=================================================
  Files          1466       1586        +120     
  Lines        433823     634947     +201124     
=================================================
+ Hits         306114     368846      +62732     
- Misses       108537     243834     +135297     
- Partials      19172      22267       +3095     

Flag	Coverage Δ
integration	40.8686% <100.0000%> (?)
unit	73.7333% <100.0000%> (+3.3498%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.3196% <ø> (+0.0256%)	:arrow_up:
parser	∅ <ø> (∅)
br	54.3181% <ø> (+8.5432%)	:arrow_up:

[tiancaiamao]

/retest-required

[tiprow[bot]]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [XuHuaiyu,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot[bot]]

[LGTM Timeline notifier]

Timeline:

• 2024-02-01 02:31:41.542410817 +0000 UTC m=+1619143.106708519: :ballot_box_with_check: agreed by XuHuaiyu.
• 2024-02-22 05:26:11.259304379 +0000 UTC m=+507660.006927483: :ballot_box_with_check: agreed by hawkingrei.

[tiancaiamao]

/retest-required

[tiprow[bot]]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiancaiamao]

/retest-required

[tiprow[bot]]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiancaiamao]

/test check-issue-triage-complete

[ti-chi-bot[bot]]

@tiancaiamao: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test canary-notify-when-compatibility-sections-changed
• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-br-integration-test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiancaiamao]

/ok-to-test

[tiprow[bot]]

@tiancaiamao: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-issue-triage-complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow[bot]]

@tiancaiamao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	0f563bfe522c3b162a065eba8e33984d1b4d8669	link	true	/test tiprow_fast_test
fast_test_tiprow	0f563bfe522c3b162a065eba8e33984d1b4d8669	link	true	/test fast_test_tiprow
tidb_parser_test	0f563bfe522c3b162a065eba8e33984d1b4d8669	link	true	/test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tiancaiamao]

/check-issue-triage-complete