statistics: remove a old logic related with statistics

[winoros]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

The code is introduced by https://github.com/pingcap/tidb/pull/6565/files#diff-5a16cfaf3a94b6aae3fafc2709020d48b95a2dd1857ccfc3d48e08ff3ed73bcaL209. Related with our old feedback logic.

This code segment will cause the following inconsistency:

• If the table has pseudo stats and there's one column/index that doesn't have stats, we will go to the Pseudo table's Copy and then we have a fake Column object for that column.
• If the table has pseudo stats, like that the bootstrap's initialization, we will create a Table object and then we don't have that fake Column object.

I think we can safely remove it since the feedback has been removed.

What changed and how does it work?

Check List

Tests

• [x] Unit test
• [x] Integration test
• [ ] Manual test (add detailed scripts or steps below)
• [ ] No need to test

  • [ ] I checked and no code files have been changed.

Side effects

• [ ] Performance regression: Consumes more CPU
• [ ] Performance regression: Consumes more Memory
• [ ] Breaking backward compatibility

Documentation

• [ ] Affects user behaviors
• [ ] Contains syntax changes
• [ ] Contains variable changes
• [ ] Contains experimental features
• [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow[bot]]

@winoros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov[bot]]

Codecov Report

:x: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.1653%. Comparing base (ff050bb) to head (c1ae55a). :warning: Report is 4095 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #50798        +/-   ##
================================================
+ Coverage   70.5750%   72.1653%   +1.5902%     
================================================
  Files          1463       1463                
  Lines        433255     433244        -11     
================================================
+ Hits         305770     312652      +6882     
+ Misses       108339     100732      -7607     
- Partials      19146      19860       +714     

Flag	Coverage Δ
integration	27.9873% <93.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	87.0645% <ø> (ø)
parser	∅ <ø> (∅)
br	76.3875% <ø> (+1.8249%)	:arrow_up:

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[winoros]

I prefer to merge this one after https://github.com/pingcap/tidb/pull/47496

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot[bot]]

[LGTM Timeline notifier]

Timeline:

• 2024-01-29 14:21:55.074737852 +0000 UTC m=+1402556.639035549: :ballot_box_with_check: agreed by hawkingrei.
• 2024-01-30 06:44:29.481178609 +0000 UTC m=+1461511.045476316: :ballot_box_with_check: agreed by AilinKid.

[hawkingrei]

/hold

[ti-chi-bot[bot]]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot[bot]]

@winoros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/mysql-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test mysql-test
idc-jenkins-ci-tidb/build	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test build
idc-jenkins-ci-tidb/unit-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test unit-test
pull-mysql-client-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-mysql-client-test
idc-jenkins-ci-tidb/check_dev_2	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test check-dev2
idc-jenkins-ci-tidb/check_dev	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test check-dev
pull-integration-ddl-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-integration-ddl-test
pull-br-integration-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-br-integration-test
pull-lightning-integration-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-lightning-integration-test
pull-integration-e2e-test	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen	c1ae55a8d0118095889b495e49f21fa7b02b2cb9	link	true	/test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.