tidb
tidb copied to clipboard
lightning: fix duplicate extend columns when resume from checkpoint
What problem does this PR solve?
Issue Number: close #50786
Problem Summary:
What changed and how does it work?
- copy ColumnPermutation for extend columns so it will not be saved in checkpoint
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
1. manually create dm task with extend column
2. pause task in load stage
3. resume task and task succeed
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from gmhdbjd. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @GMHDBJD. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/check-issue-triage-complete
Codecov Report
:x: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 78.6988%. Comparing base (51e1e13) to head (1cfc8bc).
:warning: Report is 4098 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #50787 +/- ##
================================================
+ Coverage 70.4926% 78.6988% +8.2061%
================================================
Files 1463 2091 +628
Lines 433262 687624 +254362
================================================
+ Hits 305418 541152 +235734
- Misses 108580 120834 +12254
- Partials 19264 25638 +6374
| Flag | Coverage Δ | |
|---|---|---|
| integration | 54.4306% <ø> (?) |
|
| unit | 77.0767% <72.7272%> (+5.5998%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 59.4926% <ø> (-15.7215%) |
:arrow_down: |
| parser | ∅ <ø> (∅) |
|
| br | 60.1794% <72.7272%> (-16.8186%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@GMHDBJD: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-integration-e2e-test | 1cfc8bc7357712c7a7c7e028ff46cb06e913b7f9 | link | true | /test pull-integration-e2e-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.