tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: try fix scalar agg doesn't fully pushed down to tiFlash

Open AilinKid opened this issue 1 year ago • 9 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/50583

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

AilinKid avatar Jan 26 '24 06:01 AilinKid

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from ailinkid. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 26 '24 06:01 ti-chi-bot[bot]

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Jan 26 '24 06:01 tiprow[bot]

Codecov Report

:x: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.0579%. Comparing base (c936265) to head (7791449). :warning: Report is 4245 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50749        +/-   ##
================================================
+ Coverage   70.3332%   76.0579%   +5.7246%     
================================================
  Files          1456       1465         +9     
  Lines        420707     453503     +32796     
================================================
+ Hits         295897     344925     +49028     
+ Misses       104467      87915     -16552     
- Partials      20343      20663       +320     
Flag Coverage Δ
integration 54.1042% <73.6842%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 61.7908% <ø> (+11.2788%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 26 '24 06:01 codecov[bot]

/test unit-test

AilinKid avatar Jan 29 '24 06:01 AilinKid

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Jan 29 '24 06:01 tiprow[bot]

/test unit-test

AilinKid avatar Jan 30 '24 06:01 AilinKid

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Jan 30 '24 06:01 tiprow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 12 '24 11:04 ti-chi-bot[bot]

@AilinKid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test check-dev2
pull-lightning-integration-test 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test pull-lightning-integration-test
pull-integration-e2e-test 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 7791449d5c66bfa5d21bb7177dc47e9d96a54c40 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 18:09 ti-chi-bot[bot]