tidb
tidb copied to clipboard
executor, infoschema: add ticdc into table cluster_info
What problem does this PR solve?
Issue Number: close #50723
Problem Summary: Add ticdc to table information_schema.cluster_info. Support querying log, configuration, and hardware information of ticdc through sql
What changed and how does it work?
- Read ticdc server info from
/topology/ticdc
- Add ticdc to table information_schema.cluster_info.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
- Query instance info of ticdc
- Query log of ticdc
- Query config of ticdc
- Query hardware of ticdc
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Add support for querying log, configuration, and hardware information of ticdc through sql.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Hi @CharlesCheung96. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
Merging #50523 (197f5f6) into master (5949fa5) will decrease coverage by
15.7036%
. Report is 11 commits behind head on master. The diff coverage is38.2352%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #50523 +/- ##
=================================================
- Coverage 70.6337% 54.9301% -15.7036%
=================================================
Files 1457 1568 +111
Lines 433831 610619 +176788
=================================================
+ Hits 306431 335414 +28983
- Misses 108119 251497 +143378
- Partials 19281 23708 +4427
Flag | Coverage Δ | |
---|---|---|
integration | 37.3172% <35.2941%> (?) |
|
unit | 70.5689% <26.4705%> (+0.1494%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
dumpling | 53.9957% <ø> (ø) |
|
parser | ∅ <ø> (∅) |
|
br | 51.6084% <ø> (+5.7638%) |
:arrow_up: |
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: djshow832, zimulala
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [djshow832,zimulala]
- ~~pkg/domain/OWNERS~~ [zimulala]
- ~~pkg/infoschema/OWNERS~~ [zimulala]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
/retest
@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest
@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.