tidb icon indicating copy to clipboard operation
tidb copied to clipboard

executor, infoschema: add ticdc into table cluster_info

Open CharlesCheung96 opened this issue 1 year ago • 7 comments

What problem does this PR solve?

Issue Number: close #50723

Problem Summary: Add ticdc to table information_schema.cluster_info. Support querying log, configuration, and hardware information of ticdc through sql

What changed and how does it work?

  • Read ticdc server info from /topology/ticdc
  • Add ticdc to table information_schema.cluster_info.

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.
  1. Query instance info of ticdc image
  2. Query log of ticdc image
  3. Query config of ticdc image
  4. Query hardware of ticdc image

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add support for querying log, configuration, and hardware information of ticdc through sql.

CharlesCheung96 avatar Jan 17 '24 13:01 CharlesCheung96

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Jan 17 '24 13:01 ti-chi-bot[bot]

Hi @CharlesCheung96. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Jan 17 '24 13:01 tiprow[bot]

Codecov Report

Merging #50523 (197f5f6) into master (5949fa5) will decrease coverage by 15.7036%. Report is 11 commits behind head on master. The diff coverage is 38.2352%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50523         +/-   ##
=================================================
- Coverage   70.6337%   54.9301%   -15.7036%     
=================================================
  Files          1457       1568        +111     
  Lines        433831     610619     +176788     
=================================================
+ Hits         306431     335414      +28983     
- Misses       108119     251497     +143378     
- Partials      19281      23708       +4427     
Flag Coverage Δ
integration 37.3172% <35.2941%> (?)
unit 70.5689% <26.4705%> (+0.1494%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.6084% <ø> (+5.7638%) :arrow_up:

codecov[bot] avatar Jan 25 '24 08:01 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Feb 13 '24 20:02 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 22 '24 03:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 07:59:07.152060731 +0000 UTC m=+1120388.716358428: :ballot_box_with_check: agreed by djshow832.
  • 2024-02-22 03:15:57.089419531 +0000 UTC m=+499845.837042634: :ballot_box_with_check: agreed by zimulala.

ti-chi-bot[bot] avatar Feb 22 '24 03:02 ti-chi-bot[bot]

/retest

CharlesCheung96 avatar Feb 26 '24 02:02 CharlesCheung96

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 26 '24 02:02 tiprow[bot]

/retest

CharlesCheung96 avatar Feb 26 '24 07:02 CharlesCheung96

@CharlesCheung96: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 26 '24 07:02 tiprow[bot]