tidb icon indicating copy to clipboard operation
tidb copied to clipboard

revert pd client to 0108

Open 3pointer opened this issue 1 year ago • 7 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

3pointer avatar Jan 15 '24 07:01 3pointer

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot[bot] avatar Jan 15 '24 07:01 ti-chi-bot[bot]

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Jan 15 '24 07:01 tiprow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from 3pointer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 15 '24 10:01 ti-chi-bot[bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

:open_book: For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

:open_book: For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar Jan 16 '24 08:01 ti-chi-bot[bot]

Codecov Report

:x: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.2867%. Comparing base (2ca9f98) to head (337308f). :warning: Report is 4365 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50422        +/-   ##
================================================
+ Coverage   70.0872%   74.2867%   +4.1995%     
================================================
  Files          1445       1465        +20     
  Lines        420028     457597     +37569     
================================================
+ Hits         294386     339934     +45548     
+ Misses       105358      96883      -8475     
- Partials      20284      20780       +496     
Flag Coverage Δ
integration 49.0225% <52.6315%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 53.7942% <52.6315%> (+4.0978%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 17 '24 11:02 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 08:03 ti-chi-bot[bot]

@3pointer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 337308f60325de37cc21f28f13cf505f431ef580 link true /test unit-test
pull-br-integration-test 337308f60325de37cc21f28f13cf505f431ef580 link true /test pull-br-integration-test
pull-lightning-integration-test 337308f60325de37cc21f28f13cf505f431ef580 link true /test pull-lightning-integration-test
pull-integration-e2e-test 337308f60325de37cc21f28f13cf505f431ef580 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 337308f60325de37cc21f28f13cf505f431ef580 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 337308f60325de37cc21f28f13cf505f431ef580 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 16:09 ti-chi-bot[bot]