tidb icon indicating copy to clipboard operation
tidb copied to clipboard

expression: fix the const prop over ENUM type (#50208)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #50208

What problem does this PR solve?

Issue Number: close #49440

Problem Summary:

ENUM is a hybrid type and has two possible evaluation ways.

This pull give a correct behavior for the enum and disables the propagation for other two hybrid type SET and BIT.

What changed and how does it work?

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Do the right constant propagation when the column is a ENUM

ti-chi-bot avatar Jan 10 '24 08:01 ti-chi-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 11:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:16:50.063373883 +0000 UTC m=+863498.810997009: :ballot_box_with_check: agreed by fixdb.
  • 2024-02-26 11:23:19.826551491 +0000 UTC m=+874688.574174603: :ballot_box_with_check: agreed by winoros.

ti-chi-bot[bot] avatar Feb 26 '24 11:02 ti-chi-bot[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.1@061a7da). Click here to learn what that means. The diff coverage is 51.1111%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50273   +/-   ##
================================================
  Coverage               ?   73.4354%           
================================================
  Files                  ?       1209           
  Lines                  ?     378982           
  Branches               ?          0           
================================================
  Hits                   ?     278307           
  Misses                 ?      82921           
  Partials               ?      17754           

codecov[bot] avatar Feb 26 '24 11:02 codecov[bot]

/retest

winoros avatar Feb 27 '24 10:02 winoros