tidb icon indicating copy to clipboard operation
tidb copied to clipboard

server: fix decode issue for prefetch point plan index keys (#50037)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #50037

What problem does this PR solve?

Issue Number: close #50012

Problem Summary:

The second parameter of tablecodec.DecodeHandleInUniqueIndexValue indicates whether index KVs belong to a clustered-index table. Previously, it was always false, causing decoding error and panic.

What changed and how does it work?

  • Set the parameter properly.
  • In order to pass the check like BatchGet req does not set the resource tag, tid: 123, stack: goroutine 20153 [running], I also set the resource group tagger by the digest of all SQLs.
  • Add an integration test.

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Jan 03 '24 13:01 ti-chi-bot

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:21:23.794715459 +0000 UTC m=+863772.542338570: :ballot_box_with_check: agreed by fixdb.
  • 2024-02-26 08:23:41.752152341 +0000 UTC m=+863910.499775449: :ballot_box_with_check: agreed by elsa0520.

ti-chi-bot[bot] avatar Feb 26 '24 08:02 ti-chi-bot[bot]

/retest

qw4990 avatar Feb 26 '24 10:02 qw4990

/retest

qw4990 avatar Feb 26 '24 14:02 qw4990

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.1@4d53073). Click here to learn what that means. The diff coverage is 56.5217%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50047   +/-   ##
================================================
  Coverage               ?   74.0004%           
================================================
  Files                  ?       1210           
  Lines                  ?     383968           
  Branches               ?          0           
================================================
  Hits                   ?     284138           
  Misses                 ?      82212           
  Partials               ?      17618           

codecov[bot] avatar Feb 26 '24 15:02 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, fixdb, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 27 '24 05:02 ti-chi-bot[bot]

/retest

winoros avatar Feb 27 '24 11:02 winoros