server: fix decode issue for prefetch point plan index keys (#50037)
This is an automated cherry-pick of #50037
What problem does this PR solve?
Issue Number: close #50012
Problem Summary:
The second parameter of tablecodec.DecodeHandleInUniqueIndexValue indicates whether index KVs belong to a clustered-index table. Previously, it was always false, causing decoding error and panic.
What changed and how does it work?
- Set the parameter properly.
- In order to pass the check like
BatchGet req does not set the resource tag, tid: 123, stack: goroutine 20153 [running], I also set the resource group tagger by the digest of all SQLs. - Add an integration test.
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[LGTM Timeline notifier]
Timeline:
/retest
/retest
Codecov Report
:exclamation: No coverage uploaded for pull request base (
release-7.1@4d53073). Click here to learn what that means. The diff coverage is56.5217%.
Additional details and impacted files
@@ Coverage Diff @@
## release-7.1 #50047 +/- ##
================================================
Coverage ? 74.0004%
================================================
Files ? 1210
Lines ? 383968
Branches ? 0
================================================
Hits ? 284138
Misses ? 82212
Partials ? 17618
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: elsa0520, fixdb, hawkingrei
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hawkingrei]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest