tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: fix the issue that the optimizer cannot convert OUTER JOIN to INNER JOIN with nested AND/OR in some cases (#49625)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #49625

What problem does this PR solve?

Issue Number: close #49616

Problem Summary: planner: fix the issue that the optimizer cannot convert OUTER JOIN to INNER JOIN with nested AND/OR in some cases

What changed and how does it work?

planner: fix the issue that the optimizer cannot convert OUTER JOIN to INNER JOIN with nested AND/OR in some cases

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Dec 21 '23 01:12 ti-chi-bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.1@aab2da0). Click here to learn what that means. The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #49639   +/-   ##
================================================
  Coverage               ?   73.5747%           
================================================
  Files                  ?       1209           
  Lines                  ?     379891           
  Branches               ?          0           
================================================
  Hits                   ?     279504           
  Misses                 ?      82689           
  Partials               ?      17698           

codecov[bot] avatar Feb 26 '24 11:02 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 14:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:12:48.166975021 +0000 UTC m=+863256.914598131: :ballot_box_with_check: agreed by fixdb.
  • 2024-02-26 14:51:13.23140988 +0000 UTC m=+887161.979032992: :ballot_box_with_check: agreed by qw4990.

ti-chi-bot[bot] avatar Feb 26 '24 14:02 ti-chi-bot[bot]

/test mysql-test

qw4990 avatar Feb 27 '24 01:02 qw4990

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 27 '24 01:02 tiprow[bot]

/test mysql-test

qw4990 avatar Feb 27 '24 10:02 qw4990

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 27 '24 10:02 tiprow[bot]