tidb icon indicating copy to clipboard operation
tidb copied to clipboard

br: refactor phase 1 cleanup files

Open BornChanger opened this issue 1 year ago • 7 comments

What problem does this PR solve?

Issue Number: close #41241

Problem Summary:

What changed and how does it work?

This PR is the phase 1 change of BR reorg. It removes some unnecessary files.

Check List

Tests

  • [X] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

BornChanger avatar Dec 20 '23 10:12 BornChanger

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.1400%. Comparing base (d18ee3f) to head (b13185e). Report is 2187 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #49626         +/-   ##
=================================================
+ Coverage   70.9796%   81.1400%   +10.1603%     
=================================================
  Files          1368       2502       +1134     
  Lines        398769     727939     +329170     
=================================================
+ Hits         283045     590650     +307605     
- Misses        95948     115879      +19931     
- Partials      19776      21410       +1634     
Flag Coverage Δ
integration 52.2021% <ø> (?)
unit 79.4265% <ø> (+8.4468%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+19.6466%) :arrow_up:
parser ∅ <ø> (∅)
br 67.5990% <ø> (+14.7168%) :arrow_up:

codecov[bot] avatar Dec 20 '23 10:12 codecov[bot]

/cc @3pointer @YuJuncen @Leavrth

BornChanger avatar Dec 20 '23 12:12 BornChanger

/cc @bb7133

BornChanger avatar Dec 20 '23 12:12 BornChanger

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 08:03 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 29 '24 04:04 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 04:22:49.681024414 +0000 UTC m=+244723.438159987: :ballot_box_with_check: agreed by YuJuncen.

ti-chi-bot[bot] avatar Apr 29 '24 04:04 ti-chi-bot[bot]

@BornChanger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test b13185e48d30ca37cabdf6fcb4c82dada83ed61f link true /test mysql-test
pull-lightning-integration-test b13185e48d30ca37cabdf6fcb4c82dada83ed61f link true /test pull-lightning-integration-test
pull-br-integration-test b13185e48d30ca37cabdf6fcb4c82dada83ed61f link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 31 '24 09:07 ti-chi-bot[bot]

@BornChanger what is the status of this? should this be merged once the conflicts are fixed or should it be closed?

dveeden avatar Sep 20 '24 14:09 dveeden