tidb icon indicating copy to clipboard operation
tidb copied to clipboard

planner: check whether plan-cache is disabled each time when getting plan from the plan cache (#49373)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #49373

What problem does this PR solve?

Issue Number: close #49344

Problem Summary: planner: check whether plan-cache is disabled each time when getting plan from the plan cache

What changed and how does it work?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot avatar Dec 12 '23 11:12 ti-chi-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 26 '24 10:02 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:13:28.486522478 +0000 UTC m=+863297.234145585: :ballot_box_with_check: agreed by fixdb.
  • 2024-02-26 10:41:24.001506656 +0000 UTC m=+872172.749129784: :ballot_box_with_check: agreed by qw4990.

ti-chi-bot[bot] avatar Feb 26 '24 10:02 ti-chi-bot[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.1@e091ee5). Click here to learn what that means. The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #49386   +/-   ##
================================================
  Coverage               ?   73.4722%           
================================================
  Files                  ?       1209           
  Lines                  ?     379297           
  Branches               ?          0           
================================================
  Hits                   ?     278678           
  Misses                 ?      82870           
  Partials               ?      17749           

codecov[bot] avatar Feb 26 '24 11:02 codecov[bot]

/retest

qw4990 avatar Feb 26 '24 14:02 qw4990

/test mysql-test

qw4990 avatar Feb 27 '24 01:02 qw4990

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 27 '24 01:02 tiprow[bot]

/test mysql-test

qw4990 avatar Feb 27 '24 10:02 qw4990

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow[bot] avatar Feb 27 '24 10:02 tiprow[bot]