tidb icon indicating copy to clipboard operation
tidb copied to clipboard

lightning: fix inaccurate duplicate count

Open okJiang opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/49173

Problem Summary:

  • if tidb is down when lightning record duplicate count, lightning will retry RecordDataConflictError. That cause the duplicate count is incorrect.

What changed and how does it work?

  • remove the RecordDataConflictError retry
  • add the retry count when execute SQL

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [x] No need to test
    • [ ] I checked and no code files have been changed. no logic changed

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

okJiang avatar Dec 06 '23 09:12 okJiang

/ok-to-test

okJiang avatar Dec 06 '23 09:12 okJiang

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.3026%. Comparing base (66ba419) to head (00640d1). Report is 932 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #49226         +/-   ##
=================================================
- Coverage   72.3850%   56.3026%   -16.0825%     
=================================================
  Files          1482       1620        +138     
  Lines        428662     611272     +182610     
=================================================
+ Hits         310287     344162      +33875     
- Misses        99083     243373     +144290     
- Partials      19292      23737       +4445     
Flag Coverage Δ
integration 38.5900% <100.0000%> (?)
unit 71.2329% <41.1764%> (+0.0132%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.9398% <ø> (+8.7858%) :arrow_up:

codecov[bot] avatar Dec 06 '23 10:12 codecov[bot]

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 1d1153f220ac8ddd77963cc5d3d6ee885397fb24 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Dec 07 '23 06:12 tiprow[bot]

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 1d1153f220ac8ddd77963cc5d3d6ee885397fb24 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 28 '24 11:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from okjiang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 29 '24 06:04 ti-chi-bot[bot]

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 1d1153f220ac8ddd77963cc5d3d6ee885397fb24 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Aug 28 '24 08:08 ti-chi-bot[bot]