tidb icon indicating copy to clipboard operation
tidb copied to clipboard

statistics: add bloomfilter to speedup findTopn

Open hawkingrei opened this issue 2 years ago • 6 comments

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei avatar Oct 21 '23 13:10 hawkingrei

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 21 '23 13:10 ti-chi-bot[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.7479%. Comparing base (b584055) to head (8a8bb56). :warning: Report is 5146 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47897        +/-   ##
================================================
- Coverage   71.7482%   71.7479%   -0.0004%     
================================================
  Files          1400       1400                
  Lines        405579     405571         -8     
================================================
- Hits         290996     290989         -7     
+ Misses        94846      94845         -1     
  Partials      19737      19737                
Flag Coverage Δ
integration ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 53.0414% <ø> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 21 '23 13:10 codecov[bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

:open_book: For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar Oct 23 '23 09:10 ti-chi-bot[bot]

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Oct 23 '23 09:10 tiprow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Nov 17 '23 15:11 ti-chi-bot[bot]

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test mysql-test
pull-integration-ddl-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/check_dev_2 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test check-dev2
pull-mysql-client-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test unit-test
idc-jenkins-ci-tidb/build 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test build
idc-jenkins-ci-tidb/check_dev 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test check-dev
pull-br-integration-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-br-integration-test
pull-lightning-integration-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-lightning-integration-test
pull-integration-e2e-test 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 8a8bb568c9b9fe9791f1544e27c14aba96bf0079 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 17:09 ti-chi-bot[bot]