tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: add pool from TopNFromProto

Open hawkingrei opened this issue 2 years ago • 4 comments
trafficstars

What problem does this PR solve?

Issue Number: close #46914

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei avatar Sep 13 '23 16:09 hawkingrei

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 13 '23 16:09 ti-chi-bot[bot]

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 8a41112a61b945aee6ce300b601af363036ca481 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Oct 16 '23 06:10 tiprow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Nov 17 '23 15:11 ti-chi-bot[bot]

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 8a41112a61b945aee6ce300b601af363036ca481 link true /test check-dev
idc-jenkins-ci-tidb/build 8a41112a61b945aee6ce300b601af363036ca481 link true /test build
idc-jenkins-ci-tidb/check_dev_2 8a41112a61b945aee6ce300b601af363036ca481 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test unit-test
pull-integration-ddl-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-integration-ddl-test
pull-mysql-client-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test mysql-test
pull-br-integration-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-br-integration-test
pull-lightning-integration-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-lightning-integration-test
pull-integration-e2e-test 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 8a41112a61b945aee6ce300b601af363036ca481 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Sep 26 '25 17:09 ti-chi-bot[bot]