tidb
tidb copied to clipboard
expression: enable revive
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:x: Patch coverage is 88.06818% with 21 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 73.3509%. Comparing base (bfacaf8) to head (a7e738e).
:warning: Report is 5532 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #46437 +/- ##
================================================
- Coverage 73.4371% 73.3509% -0.0863%
================================================
Files 1295 1313 +18
Lines 393753 395646 +1893
================================================
+ Hits 289161 290210 +1049
- Misses 86224 86964 +740
- Partials 18368 18472 +104
| Flag | Coverage Δ | |
|---|---|---|
| integration | 78.1388% <ø> (?) |
|
| unit | 73.3427% <88.0681%> (-0.0945%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 54.0444% <ø> (ø) |
|
| parser | 84.9520% <ø> (-0.1113%) |
:arrow_down: |
| br | 52.3426% <ø> (+0.0199%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| tiprow_fast_test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test fast_test_tiprow |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| idc-jenkins-ci-tidb/build | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test build |
| idc-jenkins-ci-tidb/check_dev | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test check-dev |
| idc-jenkins-ci-tidb/mysql-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test mysql-test |
| pull-mysql-client-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-mysql-client-test |
| pull-integration-ddl-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-integration-ddl-test |
| idc-jenkins-ci-tidb/check_dev_2 | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test check-dev2 |
| idc-jenkins-ci-tidb/unit-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test unit-test |
| pull-br-integration-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-br-integration-test |
| pull-lightning-integration-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-lightning-integration-test |
| pull-integration-e2e-test | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-integration-e2e-test |
| pull-integration-realcluster-test-next-gen | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-integration-realcluster-test-next-gen |
| pull-unit-test-next-gen | a7e738e2cb86e0622c7043d2fb705f7ef255ddfa | link | true | /test pull-unit-test-next-gen |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.