tidb
tidb copied to clipboard
feat(txmanager): add custom error for nil ctx provider
What problem does this PR solve?
Creates specific error for cases where ctx provider is nil.
Issue Number: ref #46039
Problem Summary:
What is changed and how it works?
Adds new error type for nil context provider.
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
24 out of 25 committers have signed the CLA.
:white_check_mark: Leavrth
:white_check_mark: you06
:white_check_mark: Rustin170506
:white_check_mark: lance6716
:white_check_mark: xzhangxian1008
:white_check_mark: lcwangchao
:white_check_mark: YangKeao
:white_check_mark: JmPotato
:white_check_mark: tangenta
:white_check_mark: wuhuizuo
:white_check_mark: tiancaiamao
:white_check_mark: ywqzzy
:white_check_mark: hawkingrei
:white_check_mark: Defined2014
:white_check_mark: AilinKid
:white_check_mark: qw4990
:white_check_mark: dveeden
:white_check_mark: D3Hunter
:white_check_mark: okJiang
:white_check_mark: 3pointer
:white_check_mark: zimulala
:white_check_mark: szpnygo
:white_check_mark: joccau
:white_check_mark: BornChanger
:x: kj22k0m
kj22k0m seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @gonnafaraway. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @gonnafaraway. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.
For example:
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign 3pointer, benjamin2037, easonn7, lance6716, tiancaiamao, wjhuang2016, zanmato1984 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
- OWNERS
- br/OWNERS
- br/cmd/tidb-lightning/OWNERS
- br/cmd/tidb-lightning-ctl/OWNERS
- br/pkg/lightning/OWNERS
- dumpling/OWNERS
- pkg/autoid_service/OWNERS
- pkg/config/OWNERS
- pkg/ddl/OWNERS
- pkg/distsql/OWNERS
- pkg/disttask/OWNERS
- pkg/domain/OWNERS
- pkg/executor/importer/OWNERS
- pkg/expression/OWNERS
- pkg/infoschema/OWNERS
- pkg/lock/OWNERS
- pkg/meta/OWNERS
- pkg/owner/OWNERS
- pkg/parser/OWNERS
- pkg/resourcemanager/OWNERS
- pkg/session/OWNERS
- pkg/sessionctx/variable/OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Made rebase, check plz
@3pointer @Benjamin2037 @lance6716 check plz
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.