tidb icon indicating copy to clipboard operation
tidb copied to clipboard

*: disable collecting execution info for `admin check table`

Open CbcWestwolf opened this issue 2 years ago • 11 comments
trafficstars

What problem does this PR solve?

Issue Number: close #42299

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

disable collecting execution info for admin check table

CbcWestwolf avatar Mar 20 '23 03:03 CbcWestwolf

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Mar 20 '23 03:03 ti-chi-bot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ti-chi-bot avatar Mar 20 '23 03:03 ti-chi-bot

/test all

CbcWestwolf avatar Mar 20 '23 09:03 CbcWestwolf

/test all

CbcWestwolf avatar Mar 30 '23 03:03 CbcWestwolf

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.9382%. Comparing base (ebca7ba) to head (fdd5b25). Report is 2166 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #42387        +/-   ##
================================================
- Coverage   71.0044%   68.9382%   -2.0662%     
================================================
  Files          1368       2704      +1336     
  Lines        404965     927299    +522334     
================================================
+ Hits         287543     639264    +351721     
- Misses        97427     264238    +166811     
- Partials      19995      23797      +3802     
Flag Coverage Δ
integration 40.6819% <88.8888%> (?)
unit 81.9202% <81.8181%> (+10.9158%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+19.6466%) :arrow_up:
parser ∅ <ø> (∅)
br 73.0240% <ø> (+19.9507%) :arrow_up:

codecov[bot] avatar Nov 26 '23 06:11 codecov[bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • [x] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar Nov 26 '23 08:11 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tiancaiamao Once this PR has been reviewed and has the lgtm label, please assign benjamin2037, yudongusa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 26 '23 08:11 ti-chi-bot[bot]

/retest

CbcWestwolf avatar Nov 26 '23 09:11 CbcWestwolf

@XuHuaiyu @zimulala PTAL

tiancaiamao avatar Jan 12 '24 06:01 tiancaiamao

Ping @XuHuaiyu @zimulala

tiancaiamao avatar Feb 23 '24 07:02 tiancaiamao

@CbcWestwolf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test fdd5b259d7707251c4ff0e9bf4958ea65edcb671 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow[bot] avatar Feb 27 '24 11:02 tiprow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 29 '24 18:03 ti-chi-bot[bot]

@CbcWestwolf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 fdd5b259d7707251c4ff0e9bf4958ea65edcb671 link true /test check-dev2
pull-lightning-integration-test fdd5b259d7707251c4ff0e9bf4958ea65edcb671 link true /test pull-lightning-integration-test
pull-br-integration-test fdd5b259d7707251c4ff0e9bf4958ea65edcb671 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 31 '24 10:07 ti-chi-bot[bot]