tidb icon indicating copy to clipboard operation
tidb copied to clipboard

ddl: Enable modify column on partitioned table

Open mjonss opened this issue 2 years ago • 5 comments

What problem does this PR solve?

Issue Number: close #38297 ref #39915

Similar to #39922

Problem Summary: There were an issue (#39915) with modify column on partitioned tables, which caused a revert. This will add that code back and include a fix (reset the PhysicaTablelD).

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [x] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

mjonss avatar Jan 16 '23 21:01 mjonss

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jan 16 '23 21:01 ti-chi-bot

@mjonss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Feb 18 '23 08:02 ti-chi-bot

Codecov Report

:x: Patch coverage is 74.35897% with 30 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.9269%. Comparing base (80c817a) to head (e5801cd). :warning: Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #40634        +/-   ##
================================================
+ Coverage   72.6924%   74.9269%   +2.2345%     
================================================
  Files          1866       1889        +23     
  Lines        506215     514337      +8122     
================================================
+ Hits         367980     385377     +17397     
+ Misses       115858     105223     -10635     
- Partials      22377      23737      +1360     
Flag Coverage Δ
integration 48.1063% <21.3675%> (?)
unit 72.5356% <74.3589%> (+0.2700%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1948% <ø> (+17.0161%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 27 '24 11:08 codecov[bot]

/retest

mjonss avatar Dec 07 '24 13:12 mjonss

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 07 '24 13:12 tiprow[bot]

/retest

mjonss avatar Dec 19 '24 11:12 mjonss

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Dec 19 '24 11:12 tiprow[bot]

/retest

mjonss avatar Sep 03 '25 14:09 mjonss

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Sep 03 '25 14:09 tiprow[bot]

/retest

mjonss avatar Nov 10 '25 14:11 mjonss

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Nov 10 '25 14:11 tiprow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 18 '25 11:11 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 11:01:48.509591432 +0000 UTC m=+9472.158785889: :ballot_box_with_check: agreed by wjhuang2016.

ti-chi-bot[bot] avatar Nov 18 '25 11:11 ti-chi-bot[bot]